tentacle: mon/HealthMonitor: avoid MON_DOWN for freshly added Monitor#67323
Open
batrick wants to merge 4 commits intoceph:tentaclefrom
Open
tentacle: mon/HealthMonitor: avoid MON_DOWN for freshly added Monitor#67323batrick wants to merge 4 commits intoceph:tentaclefrom
batrick wants to merge 4 commits intoceph:tentaclefrom
Conversation
batrick
force-pushed
the
wip-74043-tentacle
branch
from
b2f1ea9 to
e322e10
Compare
Config Diff Tool Output+ added: mon_down_added_grace (mon.yaml.in)
! changed: mon_down_mkfs_grace: old: (mon.yaml.in)
! changed: mon_down_mkfs_grace: new: ['runtime'] (mon.yaml.in)
The above configuration changes are found in the PR. Please update the relevant release documentation if necessary. |
Member
Author
|
/config check ok |
batrick
force-pushed
the
wip-74043-tentacle
branch
4 times, most recently
from
c5fc774 to
f468b95
Compare
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit 42a3791)
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit 62c449e)
So we know when the Monitor was added to the map. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit c5b43e9) Conflicts: src/mon/MonMap.cc: generate_test_instances refactor missing
In testing, we often have the scenario where cephadm has created a cluster but doesn't add more monitors until well past mon_down_mkfs_grace. This causes useless MON_DOWN warnings to be thrown which fails QA jobs. Avoid this situation entirely by giving a reasonable grace period for a monitor added to the MonMap to join quorum. Fixes: https://tracker.ceph.com/issues/73934 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit b028a41)
batrick
force-pushed
the
wip-74043-tentacle
branch
from
f468b95 to
6813029
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/74043
backport of #66328
parent tracker: https://tracker.ceph.com/issues/73934
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh