tentacle: os/bluestore: fix vselector update after enveloped WAL recovery#67333
Merged
batrick merged 6 commits intoceph:tentaclefrom Feb 26, 2026
Merged
Conversation
Config Diff Tool Output+ added: bluefs_check_volume_selector_on_mount (global.yaml.in)
- removed: bluefs_check_volume_selector_on_umount (global.yaml.in)
! changed: bluefs_check_volume_selector_often: old: ['bluefs_check_volume_selector_on_umount'] (global.yaml.in)
! changed: bluefs_check_volume_selector_often: new: ['bluefs_check_volume_selector_on_mount'] (global.yaml.in)
The above configuration changes are found in the PR. Please update the relevant release documentation if necessary. |
aclamk
approved these changes
Feb 12, 2026
ifed01
force-pushed
the
wip-ifed-fix-vselector-in-envmode_index_file-tent
branch
from
54f4fb3 to
6edbe04
Compare
Contributor
Author
|
jenkins test make check |
After indexing WAL envelope files update of actual file size was forgotten. Strangely, it does not affect RocksDB WAL recovery procedure. Fixes: https://tracker.ceph.com/issues/74091 Signed-off-by: Adam Kupczyk <akupczyk@ibm.com> (cherry picked from commit 5a13df1)
… setting. This is bluefs_check_volume_selector_on_mount now and enables volume selector validation on both mount and umount. Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit 777783f)
We'll need it from test_bluefs.cc and hence better move out of BlueStore.cc to not expose it for the tests. Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit 42b25e5)
recovering WAL in envelope mode. Reproduces: https://tracker.ceph.com/issues/74765 Exact bug reproduction (which occurs on file removal) requires 'bluefs_check_volume_selector_on_mount' to be set manually to false in 'wal_v2_simulate_crash' test case. That's not the case for the default implementation which fails volume selector validation at earlier stage during BlueFS mount. This seems a general approach which provides better test coverage. Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit e65564e)
envelope mode. Fixes: https://tracker.ceph.com/issues/74765 Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit 7807e11)
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io> (cherry picked from commit 03ef619)
ifed01
force-pushed
the
wip-ifed-fix-vselector-in-envmode_index_file-tent
branch
from
6edbe04 to
6535621
Compare
Member
|
/config check ok |
Contributor
Contributor
Author
|
@batrick - ready to merge |
|
This is an automated message by src/script/redmine-upkeep.py. I have resolved the following tracker ticket due to the merge of this PR: No backports are pending for the ticket. If this is incorrect, please update the tracker Update Log: https://github.com/ceph/ceph/actions/runs/22445112394 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is already contains fix from #67208
It is enough to merge this one.
Fixes: https://tracker.ceph.com/issues/74732
Fixes: https://tracker.ceph.com/issues/74882
Backport of #67312
Backport of #66512
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.