Add quincy support to our CI tests#659
Merged
mergify[bot] merged 14 commits intoceph:masterfrom May 2, 2022
Merged
Conversation
phlogistonjohn
force-pushed
the
jjm-quincy
branch
from
85a12a5 to
a3e3b91
Compare
Collaborator
Author
|
Well.... the quincy instance seems flaky as flaky gets but I think I've now identified all the tests that are currently guaranteed to fail. These FIXME commits need to be removed of course. In the short term I'll look into making them skips for quincy only. |
Collaborator
Author
|
filed https://tracker.ceph.com/issues/55094 for the rbd admin snapshot test failure |
phlogistonjohn
force-pushed
the
jjm-quincy
branch
2 times, most recently
from
2beb71f to
66130fb
Compare
phlogistonjohn
force-pushed
the
jjm-quincy
branch
2 times, most recently
from
b788952 to
cee4fa7
Compare
Collaborator
Author
|
https://ceph.io/en/news/blog/2022/v17-2-0-quincy-released/ Quincy is now released. I'd like to prioritize this general effort for our next release. I'd like to run with this PR's approach of getting the release enabled in the CI with some tests disabled and then we can work the individual disabled tests separately. Any objections/thoughts/questions? If I don't hear back I'll make this ready-for-review and start pushing that plan. Thanks! |
phlogistonjohn
added
the
no-API
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
phlogistonjohn
force-pushed
the
jjm-quincy
branch
from
cee4fa7 to
257b41e
Compare
Collaborator
Author
|
🎉 All dependencies have been resolved ! |
ansiwen
reviewed
Apr 28, 2022
Collaborator
ansiwen
left a comment
ansiwen
left a comment
There was a problem hiding this comment.
LGTM overall, just two questions.
Collaborator
Author
|
@Mergifyio rebase |
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
This issue should no longer be present in the base containers. Signed-off-by: John Mulligan <jmulligan@redhat.com>
The "CEPH_FEATURES" env var can now be used to exactly control what steps will be run. If unset the steps will be derived from the CEPH_VERSION env var. Best viewed by ignoring whitespace. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
…emon Signed-off-by: John Mulligan <jmulligan@redhat.com>
See also: * https://tracker.ceph.com/issues/52103 * ceph/ceph#42718 Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
It appears the JSON being returned from `ceph fs status` has changed. The field returning the mds version was previously "just" a string. Now its a more complex thing. This of course breaks the old version of the go code which is statically typed to expect a string. In order not to break backwards compatibility we replace the object used for parsing the JSON with a private object that has a custom unmarshaller function for the mds version field. If it sees the string it uses the string. Otherwise, it looks for this new structure and, if possible, extracts the version string from the first item. Signed-off-by: John Mulligan <jmulligan@redhat.com>
On ceph quincy, removing the subvolume explicitly (even with --force) triggered an error. Due to the discussion in https://tracker.ceph.com/issues/54625 I was informed that the explicit delete was not necessary, and while the error on quincy was not correct, even on previous versions the call is basically a no-op. Rather than wait for this to be changed back to a no-op on quincy, we remove the unneeded call. While we're at it, change the polling loop to use the assert lib's Eventually call which is much nicer to read and expires based on a duration avoiding the need to think about loop iterations. :-) Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
This test feels very flaky, only passing 2-3 times out of ten (by my vague guesstimate). This needs investigation. However I don't want to block all of CI against quincy for this this now. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Will need to be properly debugged later. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Mysteriously fails without a useful error. Will need to be properly debugged later. Signed-off-by: John Mulligan <jmulligan@redhat.com>
✅ Branch has been successfully rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #649
Fixes #657
Depends on: #674
This PR adds initial support for Ceph 'quincy'.
There are a few sub-topics here: let me know if you think it's better if I split them out as separate PRs.
Some tests currently don't work right on quincy and these have been disabled by skip-test calls. If this PR is merged the skips will be filed as issues and we can track and resolve them separately.
(Updated 2022-04-25)
Checklist