Skip to content

rbd admin: enable TestMirrorSnapshotScheduleStatus on qunicy#686

Merged
mergify[bot] merged 1 commit intoceph:masterfrom
phlogistonjohn:jjm-enable-MirrorSnapshotScheduleStatus
Jun 14, 2022
Merged

rbd admin: enable TestMirrorSnapshotScheduleStatus on qunicy#686
mergify[bot] merged 1 commit intoceph:masterfrom
phlogistonjohn:jjm-enable-MirrorSnapshotScheduleStatus

Conversation

@phlogistonjohn
Copy link
Collaborator

@phlogistonjohn phlogistonjohn commented May 10, 2022

fixes #680

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Is this new API marked PREVIEW?

@phlogistonjohn phlogistonjohn force-pushed the jjm-enable-MirrorSnapshotScheduleStatus branch from 0a3f25a to 05b2061 Compare May 11, 2022 14:39
@phlogistonjohn
Copy link
Collaborator Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Jun 6, 2022

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn force-pushed the jjm-enable-MirrorSnapshotScheduleStatus branch from 05b2061 to da84666 Compare June 6, 2022 14:13
@phlogistonjohn
Copy link
Collaborator Author

@Mergifyio rebase

The issue has (probably) been fixed in ceph v17.2.0 images.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@mergify
Copy link

mergify bot commented Jun 13, 2022

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn force-pushed the jjm-enable-MirrorSnapshotScheduleStatus branch from da84666 to 582d75e Compare June 13, 2022 17:20
@phlogistonjohn phlogistonjohn marked this pull request as ready for review June 13, 2022 18:13
@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Jun 13, 2022
@phlogistonjohn phlogistonjohn requested a review from ansiwen June 13, 2022 18:14
@phlogistonjohn phlogistonjohn changed the title experiment to reenable TestMirrorSnapshotScheduleStatus on qunicy rbd admin: enable TestMirrorSnapshotScheduleStatus on qunicy Jun 13, 2022
@phlogistonjohn
Copy link
Collaborator Author

@ansiwen I realized that this can go in the release, it was just getting bit by test flakes. It is not needed for the release, so this can be low priority.

Copy link
Collaborator

@ansiwen ansiwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 0722af5 into ceph:master Jun 14, 2022
@phlogistonjohn phlogistonjohn deleted the jjm-enable-MirrorSnapshotScheduleStatus branch October 24, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-API This PR does not include any changes to the public API of a go-ceph package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quincy] rbd/admin: Fix TestMirrorSnapshotScheduleStatus

2 participants