implements: don't rely on PREVIEW comments but on ceph_preview tag#693
implements: don't rely on PREVIEW comments but on ceph_preview tag#693mergify[bot] merged 3 commits intomasterfrom
ceph_preview tag#693Conversation
ansiwen
added
the
no-API
phlogistonjohn
left a comment
phlogistonjohn
left a comment
There was a problem hiding this comment.
Looks really good. There's one typo that needs fixing. I also have a question about the function that examines the build tags - but it's not a blocking one.
|
It appears that the tests are failing due to changes here too. It's possible that the json now being generated is not 100% in sync with what we were detecting before? I'll leave it for you to investigate. :-) |
ansiwen
force-pushed
the
pr/ansiwen/no-preview-comments
branch
from
3178fed to
029e6b6
Compare
ansiwen
changed the title
ceph_preview tagceph_preview tag
ansiwen
force-pushed
the
pr/ansiwen/no-preview-comments
branch
from
029e6b6 to
5c6ea2f
Compare
My code simply didn’t work, fixed it. Now it’s only failing in TestCancelClone, which is not related. |
|
@Mergifyio rebase |
Signed-off-by: Sven Anderson <sven@redhat.com>
Signed-off-by: Sven Anderson <sven@redhat.com>
Signed-off-by: Sven Anderson <sven@redhat.com>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
pr/ansiwen/no-preview-comments
branch
from
5c6ea2f to
68e39f3
Compare
phlogistonjohn
left a comment
phlogistonjohn
left a comment
There was a problem hiding this comment.
LGTM. I think it will be nice simplification of the workflow.
2 participants
Signed-off-by: Sven Anderson sven@redhat.com