cephfs: add subvolume snapshot metadata APIs#698
Merged
mergify[bot] merged 1 commit intoceph:masterfrom Jun 13, 2022
Merged
Conversation
pkalever
force-pushed
the
snapshot-metadata
branch
from
ad63fc4 to
4cd1c84
Compare
phlogistonjohn
added
the
API
Collaborator
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
snapshot-metadata
branch
from
4cd1c84 to
cd80d6e
Compare
Collaborator
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
snapshot-metadata
branch
from
cd80d6e to
4dd5519
Compare
pkalever
force-pushed
the
snapshot-metadata
branch
from
4dd5519 to
2c09d3f
Compare
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Jun 8, 2022
This is needed for now, ceph/go-ceph#698 This PR at go-ceph add subvolume snapshot metadata APIs. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Jun 8, 2022
This is needed for now, ceph/go-ceph#698 This PR at go-ceph add subvolume snapshot metadata APIs. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Jun 8, 2022
This is needed for now, ceph/go-ceph#698 This PR at go-ceph add subvolume snapshot metadata APIs. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Jun 8, 2022
This is needed for now, ceph/go-ceph#698 This PR at go-ceph add subvolume snapshot metadata APIs. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Author
|
@Mergifyio rebase |
☑️ Nothing to doDetails
|
Author
|
@phlogistonjohn @ansiwen could you please help review. |
Collaborator
Author
Yes @phlogistonjohn I will address the comments and rebase this resolving the conflicting parts post #691 merge. |
pkalever
pushed a commit
to pkalever/ceph-csi
that referenced
this pull request
Jun 10, 2022
This is needed for now, ceph/go-ceph#698 This PR at go-ceph add subvolume snapshot metadata APIs. Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
pkalever
force-pushed
the
snapshot-metadata
branch
2 times, most recently
from
4c63e9f to
3beae75
Compare
ansiwen
approved these changes
Jun 13, 2022
Collaborator
ansiwen
left a comment
ansiwen
left a comment
There was a problem hiding this comment.
LGTM. When my approval gets lost later after rebasing, feel free to merge it also without me re-approval.
Collaborator
|
@Mergifyio rebase |
Exports below APIs: SetSnapshotMetadata(), GetSnapshotMetadata(), RemoveSnapshotMetadata(), ForceRemoveSnapshotMetadata() and ListSnapshotMetadata() Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
✅ Branch has been successfully rebased |
ktdreyer
force-pushed
the
snapshot-metadata
branch
from
3beae75 to
e384d45
Compare
phlogistonjohn
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exports below APIs:
SetSnapshotMetadata,
GetSnapshotMetadata(),
RemoveSnapshotMetadata(),
ForceRemoveSnapshotMetadata() and
ListSnapshotMetadata()
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Checklist
Additional information to reviewers/Maintainers:
This PR needs ceph/ceph#46086 which is not merged upstream yet, but the cmd schemas will mostly be same.Update: ceph/ceph#46086 is merged upstream now.