rados: Implement rados_set_alloc_hint2#710
Conversation
Heh. That's unfortunate. I suppose we can just add a few calls to the function with 2-3 of the various flags along with some other ops. This way we at least see that it doesn't segfault or anything like that. It's not the best test in the world but IMO better than nothing. Can you please do something like that? Once done, I can activate the CI and we'll be sure it compiles and executes even if we can't assert anything about it beyond that. |
14a0e52 to
3a364f8
Compare
|
Hey @phlogistonjohn, I added the tests you suggested 👍 |
phlogistonjohn
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
3a364f8 to
4054294
Compare
Pull request has been modified.
4054294 to
c057cb5
Compare
Signed-off-by: Quentin Devos <4972091+Okhoshi@users.noreply.github.com>
c057cb5 to
55d0bd6
Compare
Signed-off-by: Quentin Devos 4972091+Okhoshi@users.noreply.github.com
Add support in go-ceph:
Closes #697
Checklist
//go:build ceph_previewI'm not sure how I'm supposed to test the Allocation Hint, especially since I'm not aware of a way to check the Allocation hints set on a file, and that the functions never return errors.