apiage: Do not leave empty sections for packages in markdown#753
Merged
mergify[bot] merged 1 commit intoceph:masterfrom Aug 12, 2022
Merged
apiage: Do not leave empty sections for packages in markdown#753mergify[bot] merged 1 commit intoceph:masterfrom
mergify[bot] merged 1 commit intoceph:masterfrom
Conversation
anoopcs9
force-pushed
the
fix-empty-pkg-hdr
branch
2 times, most recently
from
3cebbc4 to
bf5d4fd
Compare
anoopcs9
force-pushed
the
fix-empty-pkg-hdr
branch
2 times, most recently
from
07c97ef to
fcc5ce4
Compare
phlogistonjohn
approved these changes
Aug 11, 2022
Collaborator
phlogistonjohn
left a comment
phlogistonjohn
left a comment
There was a problem hiding this comment.
Change looks great. However we need to resolve the outstanding CI issue with revive prior to merging.
Collaborator
Author
|
@Mergifyio rebase |
For those packages without any preview/deprecated APIs we used to include a header despite any content under it. We could instead mention the state in a meaningful sentence. Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
fix-empty-pkg-hdr
branch
from
fcc5ce4 to
4ebfb87
Compare
anoopcs9
added
the
no-API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For those packages without any preview/deprecated APIs we used to include a header despite any content under it. We could instead mention the state in a meaningful sentence.
Fixes: #595