Switch to gcr.io/distroless/static base image#1663
Switch to gcr.io/distroless/static base image#1663jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: James Munnelly <james@munnelly.eu>
|
Would appreciate your thoughts on this change, esp. regarding debug-ability @simonswine @kragniz @Evesy I'd hope that we can all get used to attaching additional containers to our pods, but maybe I'm overly hopeful 😅 |
|
/cc @kragniz |
|
/retest |
15 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
12 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
Seems like a reasonable change, I imagine most people are comfortable enough running their own pods for debugging given the amount of OSS docker images that are based on minimal scratch images. Should be even better when kubernetes/enhancements#277 eventually makes its way in 👍 |
|
/retest |
13 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
Thanks for the comments @Evesy, and sorry for the bot spam on this one... our test infra ran into a few issues last week and I've not been around to fix it 🙈 |
What this PR does / why we need it:
This PR switches all cert-manager images to use 'gcr.io/distroless/static' as a base.
This image contains pretty much just ca-certificates, which makes it perfect for what we need.
distroless/static does not include any binaries at all, meaning the base image is by default multi-arch 😄
Users wanting to debug from within the cert-manager pod will need to attach an additional container with their debug utilities to the pod's namespaces.
Release note: