Skip to content

Add support to allow CRD conversion webhooks from outside of the cluster#3932

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
anton-johansson:also-handle-conversion-webhook-from-outside-the-cluster
Apr 28, 2021
Merged

Add support to allow CRD conversion webhooks from outside of the cluster#3932
jetstack-bot merged 1 commit intocert-manager:masterfrom
anton-johansson:also-handle-conversion-webhook-from-outside-the-cluster

Conversation

@anton-johansson
Copy link
Copy Markdown
Contributor

@anton-johansson anton-johansson commented Apr 28, 2021 •
edited
Loading

Related to #3876

What this PR does / why we need it:

See #3876

Special notes for your reviewer:

Very similar to #3876, just addition for CRD conversions.

Release note:

NONE

@anton-johansson
Add support to allow CRD conversion webhooks from outside of the cluster
96a0859 
Related to cert-manager#3876

Signed-off-by: Anton Johansson <hello@anton-johansson.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Apr 28, 2021

Hi @anton-johansson. Thanks for your PR.

I'm waiting for a jetstack or cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/deploy Indicates a PR modifies deployment configuration release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 28, 2021
@munnerz
Copy link
Copy Markdown
Member

munnerz commented Apr 28, 2021

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 28, 2021
@jakexks
Copy link
Copy Markdown
Member

jakexks commented Apr 28, 2021

/ok-to-test
/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Apr 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anton-johansson, jakexks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@anton-johansson anton-johansson mentioned this pull request Apr 28, 2021
Merged
@jakexks
Copy link
Copy Markdown
Member

jakexks commented Apr 28, 2021

/kind feature

@jetstack-bot jetstack-bot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 28, 2021
@jakexks
Copy link
Copy Markdown
Member

jakexks commented Apr 28, 2021

/test pull-cert-manager-bazel

@jetstack-bot jetstack-bot merged commit 8d794c6 into cert-manager:master Apr 28, 2021
@jetstack-bot jetstack-bot added this to the v1.4 milestone Apr 28, 2021
@wallrj wallrj mentioned this pull request Apr 30, 2021
Closed
@maelvls maelvls mentioned this pull request May 12, 2021
Closed
@maelvls maelvls mentioned this pull request Mar 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jakexks jakexks

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.4

Development

Successfully merging this pull request may close these issues.

4 participants

@anton-johansson @jetstack-bot @munnerz @jakexks