Skip to content

Licenses: support local licenses, add LICENSES to repo root and use local LICENSE file#284

Merged
cert-manager-prow[bot] merged 3 commits into
cert-manager:mainfrom
inteon:licenses_go.work
Apr 29, 2025
Merged

Licenses: support local licenses, add LICENSES to repo root and use local LICENSE file#284
cert-manager-prow[bot] merged 3 commits into
cert-manager:mainfrom
inteon:licenses_go.work

Conversation

@inteon
Copy link
Copy Markdown
Member

@inteon inteon commented Apr 28, 2025

While working on making cert-manager/cert-manager use makefile modules more, I found 3 improvements for the licenses makefile module:

inteon added 3 commits April 27, 2025 23:57
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
…le next to the go.mod file

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2025
@inteon inteon changed the title Licenses makefile module: support local licenses, add LICENSES to repo root and use local LICENSE file Licenses: support local licenses, add LICENSES to repo root and use local LICENSE file Apr 28, 2025
@maelvls
Copy link
Copy Markdown
Member

maelvls commented Apr 29, 2025

haven't tested manually, looks good

/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2025
@inteon
Copy link
Copy Markdown
Member Author

inteon commented Apr 29, 2025

/approve

@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@cert-manager-prow cert-manager-prow Bot merged commit 1373fbc into cert-manager:main Apr 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants