Skip to content

feat(tools): adding envtest support for customManagers - #418

Merged
cert-manager-prow[bot] merged 2 commits into
cert-manager:mainfrom
hjoshi123:feat/add-envtest-template
Sep 7, 2025
Merged

feat(tools): adding envtest support for customManagers#418
cert-manager-prow[bot] merged 2 commits into
cert-manager:mainfrom
hjoshi123:feat/add-envtest-template

Conversation

@hjoshi123

Copy link
Copy Markdown
Contributor

No description provided.

@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2025
@hjoshi123
hjoshi123 force-pushed the feat/add-envtest-template branch 6 times, most recently from 8e329be to 8b75ccc Compare September 6, 2025 22:04
Signed-off-by: hjoshi123 <mail@hjoshi.me>
@hjoshi123
hjoshi123 force-pushed the feat/add-envtest-template branch from 8b75ccc to 4f39423 Compare September 7, 2025 17:47
@hjoshi123

Copy link
Copy Markdown
Contributor Author

/label tide/merge-method-squash

@cert-manager-prow cert-manager-prow Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 7, 2025

@erikgb erikgb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a fork and with the renovate/reconfigure branch: #419 (comment)

Thanks a lot for this, @hjoshi123! 🚀

/label tide/merge-method-squash
/lgtm
/approve

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2025
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2025
@cert-manager-prow
cert-manager-prow Bot merged commit e048900 into cert-manager:main Sep 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants