Fix protoc version notifier - #431
Merged
cert-manager-prow[bot] merged 1 commit intoSep 13, 2025
Merged
Conversation
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
cert-manager-prow
Bot
added
dco-signoff: yes
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the protoc version notifier to align with the Renovate datasource for GitHub releases by adding a 'v' prefix to the version string and updating the download URL to handle the versioned tag format.
- Updates protoc version from "32.0" to "v32.0" to match GitHub release tag format
- Modifies download URL to use the version tag directly and strip the 'v' prefix for the filename
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
cert-manager-prow
Bot
requested review from
ThatsMrTalbot,
hjoshi123 and
inteon
September 13, 2025 08:58
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ThatsMrTalbot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns the
protocversion notifier with the Renovate datasource (GitHub releases) used for this dependency. Hopefully, this will fix the current broken tools upgrade PR, #430.The solution is similar to what we ultimately used for the Vault dependency in #353.