Skip to content

Fix addLabels in Renovate config#646

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:fix-add-labels
Jun 15, 2026
Merged

Fix addLabels in Renovate config#646
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:fix-add-labels

Conversation

@erikgb

@erikgb erikgb commented Jun 15, 2026

Copy link
Copy Markdown
Member

This is correcting a bug in #643. I unintentionally put the new addLabels field under postUpgradeTasks, which is obviously wrong.

@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2026
@erikgb
erikgb requested a review from Copilot June 15, 2026 18:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Renovate configuration regression introduced in PR #643 by relocating addLabels to the correct level within the relevant packageRules entry, so Renovate’s self-upgrade PRs regain the skip-review label needed for auto-merge behavior.

Changes:

  • Moves addLabels out of postUpgradeTasks and into the package rule object where Renovate expects it.
  • Ensures Renovate PRs created by the custom.jsonata manager for klone.yaml receive the skip-review label.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@cert-manager-prow cert-manager-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 15, 2026
@erikgb

erikgb commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

/cc @ThatsMrTalbot

@ThatsMrTalbot

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ThatsMrTalbot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2026
@cert-manager-prow
cert-manager-prow Bot merged commit 7835ffe into cert-manager:main Jun 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants