Skip to content

Remove all configuration for cert-manager 1.14 #1064

Merged
cert-manager-prow[bot] merged 5 commits intocert-manager:masterfrom
wallrj:remove-1.14-periodics
Oct 7, 2024
Merged

Remove all configuration for cert-manager 1.14 #1064
cert-manager-prow[bot] merged 5 commits intocert-manager:masterfrom
wallrj:remove-1.14-periodics

Conversation

@wallrj
Copy link
Copy Markdown
Member

@wallrj wallrj commented Oct 3, 2024 •
edited
Loading

cert-manager 1.14 is no longer supported since the release of 1.16,
so removing all the testing configuration,
as per the release process:

(final release only) Create a PR on cert-manager/testing, removing any unsupported release versions from prow config.

Only remaining reference to release-1.14 is in the milestone applier config, but all previous releases have left that in place:

$ git grep  -C 10 release-1.14
config/plugins.yaml-    maintainers_team: milestone-maintainers
config/plugins.yaml-  cert-manager/trust-manager:
config/plugins.yaml-    # https://github.com/orgs/cert-manager/teams/milestone-maintainers
config/plugins.yaml-    maintainers_team: milestone-maintainers
config/plugins.yaml-
config/plugins.yaml-milestone_applier:
config/plugins.yaml-  cert-manager/cert-manager:
config/plugins.yaml-    master: v1.17
config/plugins.yaml-    release-1.16: v1.16
config/plugins.yaml-    release-1.15: v1.15
config/plugins.yaml:    release-1.14: v1.14
config/plugins.yaml-    release-1.12: v1.12
config/plugins.yaml-    release-1.11: v1.11
config/plugins.yaml-    release-1.10: v1.10
config/plugins.yaml-    release-1.9: v1.9
config/plugins.yaml-    release-1.8: v1.8
config/plugins.yaml-    release-1.7: v1.7
config/plugins.yaml-    release-1.6: v1.6
config/plugins.yaml-    release-1.5: v1.5
config/plugins.yaml-    release-1.4: v1.4
config/plugins.yaml-    release-1.3: v1.3

wallrj added 5 commits October 3, 2024 17:50
@wallrj
Update the prow spec.go file
de1a35f 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
make prowgen
2e0c8de 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
rm -rf config/jobs/cert-manager/cert-manager/release-1.14
096e6d0 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
Remove the branch protection
b353164 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@wallrj
Remove testgrid dashboards
df3d2fd 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 3, 2024
wallrj
wallrj commented Oct 3, 2024
View reviewed changes
Comment thread config/jobs/cert-manager/cert-manager/release-1.15/cert-manager-release-1.15.yaml
Copy link
Copy Markdown
Member Author

@wallrj wallrj Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cron schedules were updated by make prowgen.

Comment thread config/jobs/cert-manager/cert-manager/release-1.16/cert-manager-release-1.16.yaml
Copy link
Copy Markdown
Member Author

@wallrj wallrj Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cron schedules were updated by make prowgen.

@wallrj wallrj requested a review from maelvls October 3, 2024 16:59
maelvls
maelvls approved these changes Oct 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2024
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@cert-manager-prow cert-manager-prow bot merged commit 579d93a into cert-manager:master Oct 7, 2024
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Oct 7, 2024

@wallrj: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster default using the following files:
    • key cert-manager-release-1.14.yaml using file ``
    • key cert-manager-release-1.15.yaml using file config/jobs/cert-manager/cert-manager/release-1.15/cert-manager-release-1.15.yaml
    • key cert-manager-release-1.16.yaml using file config/jobs/cert-manager/cert-manager/release-1.16/cert-manager-release-1.16.yaml
  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/config.yaml
Details

In response to this:

cert-manager 1.14 is no longer supported since the release of 1.16,
so removing all the testing configuration,
as per the release process:

(final release only) Create a PR on cert-manager/testing, removing any unsupported release versions from prow config.

Only remaining reference to release-1.14 is in the milestone applier config, but all previous releases have left that in place:

$ git grep  -C 10 release-1.14
config/plugins.yaml-    maintainers_team: milestone-maintainers
config/plugins.yaml-  cert-manager/trust-manager:
config/plugins.yaml-    # https://github.com/orgs/cert-manager/teams/milestone-maintainers
config/plugins.yaml-    maintainers_team: milestone-maintainers
config/plugins.yaml-
config/plugins.yaml-milestone_applier:
config/plugins.yaml-  cert-manager/cert-manager:
config/plugins.yaml-    master: v1.17
config/plugins.yaml-    release-1.16: v1.16
config/plugins.yaml-    release-1.15: v1.15
config/plugins.yaml:    release-1.14: v1.14
config/plugins.yaml-    release-1.12: v1.12
config/plugins.yaml-    release-1.11: v1.11
config/plugins.yaml-    release-1.10: v1.10
config/plugins.yaml-    release-1.9: v1.9
config/plugins.yaml-    release-1.8: v1.8
config/plugins.yaml-    release-1.7: v1.7
config/plugins.yaml-    release-1.6: v1.6
config/plugins.yaml-    release-1.5: v1.5
config/plugins.yaml-    release-1.4: v1.4
config/plugins.yaml-    release-1.3: v1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wallrj wallrj deleted the remove-1.14-periodics branch October 7, 2024 15:04
@wallrj-cyberark wallrj-cyberark mentioned this pull request Apr 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maelvls maelvls maelvls approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wallrj @maelvls