Conversation
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
wallrj-cyberark
left a comment
There was a problem hiding this comment.
This looks like a duplicate of #1164 by @maelvls, which was opened two weeks earlier (March 27) and already has /lgtm from you. Both PRs do the same thing: remove release-1.18 from prowgen specs, delete the job yaml, remove branch protection + testgrid entries, bump cert-manager_install.sh, and regenerate cron schedules.
Differences:
- #1164 also updates the Kubernetes version matrix for the remaining branches (dropping K8s 1.31/1.32, adding 1.35) and updates
master/cert-manager-master.yaml— this PR doesn't touch the K8s version matrix or master jobs - #1164 bumps to v1.20.0, this PR bumps to v1.20.1
- #1164 links to the release process docs and parent issue cert-manager/cert-manager#8656 for context
Should this PR be closed in favour of #1164? Or is there a reason to prefer this one (e.g. if Maël's PR is stale and harder to rebase)?
Also — can you confirm this was generated by running prowgen --branch=* -o cert-manager after editing specs.go? The cron schedule shifts in release-1.19 and release-1.20 look like prowgen output, but it would be good to confirm.
Review conducted with assistance from Claude (Opus 4.6)
Hahaha, "already has /close |
|
@erikgb: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
I noticed that our TestGrid contains cert-manager 1.18 references: https://testgrid.k8s.io/cert-manager. As cert-manager 1.18 is currently out of support, I propose to clean out any refs to it from this repo.