Skip to content

Clean out unsupported cm 1.18#1168

Closed
erikgb wants to merge 1 commit intocert-manager:masterfrom
erikgb:clean-out-cm-1-18
Closed

Clean out unsupported cm 1.18#1168
erikgb wants to merge 1 commit intocert-manager:masterfrom
erikgb:clean-out-cm-1-18

Conversation

@erikgb
Copy link
Copy Markdown
Member

@erikgb erikgb commented Apr 11, 2026

I noticed that our TestGrid contains cert-manager 1.18 references: https://testgrid.k8s.io/cert-manager. As cert-manager 1.18 is currently out of support, I propose to clean out any refs to it from this repo.

Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Apr 11, 2026
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshvanl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 11, 2026
Copy link
Copy Markdown
Member

@wallrj-cyberark wallrj-cyberark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a duplicate of #1164 by @maelvls, which was opened two weeks earlier (March 27) and already has /lgtm from you. Both PRs do the same thing: remove release-1.18 from prowgen specs, delete the job yaml, remove branch protection + testgrid entries, bump cert-manager_install.sh, and regenerate cron schedules.

Differences:

  • #1164 also updates the Kubernetes version matrix for the remaining branches (dropping K8s 1.31/1.32, adding 1.35) and updates master/cert-manager-master.yaml — this PR doesn't touch the K8s version matrix or master jobs
  • #1164 bumps to v1.20.0, this PR bumps to v1.20.1
  • #1164 links to the release process docs and parent issue cert-manager/cert-manager#8656 for context

Should this PR be closed in favour of #1164? Or is there a reason to prefer this one (e.g. if Maël's PR is stale and harder to rebase)?

Also — can you confirm this was generated by running prowgen --branch=* -o cert-manager after editing specs.go? The cron schedule shifts in release-1.19 and release-1.20 look like prowgen output, but it would be good to confirm.

Review conducted with assistance from Claude (Opus 4.6)

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 11, 2026

This looks like a duplicate of #1164 by @maelvls, which was opened two weeks earlier (March 27) and already has /lgtm from you. Both PRs do the same thing: remove release-1.18 from prowgen specs, delete the job yaml, remove branch protection + testgrid entries, bump cert-manager_install.sh, and regenerate cron schedules.

Differences:

Should this PR be closed in favour of #1164? Or is there a reason to prefer this one (e.g. if Maël's PR is stale and harder to rebase)?

Also — can you confirm this was generated by running prowgen --branch=* -o cert-manager after editing specs.go? The cron schedule shifts in release-1.19 and release-1.20 look like prowgen output, but it would be good to confirm.

Review conducted with assistance from Claude (Opus 4.6)

Hahaha, "already has /lgtm from you"! I'll close this in favor of @maelvls PR. I was focused on the cert-manager patch release. 🙊

/close

@cert-manager-prow
Copy link
Copy Markdown
Contributor

@erikgb: Closed this PR.

Details

In response to this:

This looks like a duplicate of #1164 by @maelvls, which was opened two weeks earlier (March 27) and already has /lgtm from you. Both PRs do the same thing: remove release-1.18 from prowgen specs, delete the job yaml, remove branch protection + testgrid entries, bump cert-manager_install.sh, and regenerate cron schedules.

Differences:

Should this PR be closed in favour of #1164? Or is there a reason to prefer this one (e.g. if Maël's PR is stale and harder to rebase)?

Also — can you confirm this was generated by running prowgen --branch=* -o cert-manager after editing specs.go? The cron schedule shifts in release-1.19 and release-1.20 look like prowgen output, but it would be good to confirm.

Review conducted with assistance from Claude (Opus 4.6)

Hahaha, "already has /lgtm from you"! I'll close this in favor of @maelvls PR. I was focused on the cert-manager patch release. 🙊

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants