Skip to content

Remove cert-manager release-1.19 testing configuration#1218

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:masterfrom
wallrj-cyberark:release-1.21-remove-unsupported
Jul 10, 2026
Merged

Remove cert-manager release-1.19 testing configuration#1218
cert-manager-prow[bot] merged 1 commit into
cert-manager:masterfrom
wallrj-cyberark:release-1.21-remove-unsupported

Conversation

@wallrj-cyberark

Copy link
Copy Markdown
Member

Motivation

cert-manager 1.19 is no longer supported since the release of 1.21, so removing all the testing configuration, as per the release process:

(final release only) Create a PR on cert-manager/testing, removing any unsupported release versions from prow config.

Changes

  • Remove release-1.19 from prowgen knownBranches
  • Delete release-1.19 prow job spec and associated periodics
  • Remove release-1.19 branch-protection entry
  • Remove release-1.19 milestone applier mapping
  • Remove release-1.19 testgrid dashboard
  • Bump cert-manager helm install version to v1.20.3
  • Adjust cron schedules for release-1.20 and release-1.21 periodics; a side-effect of running make prowgen

Test Plan

  • Ran make prowgen to regenerate job configurations
  • Verified all release-1.19 references removed from:
    • config/prowgen/prowspecs/specs.go
    • config/config.yaml (branch protection)
    • config/plugins.yaml (milestone applier)
    • config/testgrid/dashboards.yaml
    • config/jobs/cert-manager/cert-manager/release-1.19/
  • Updated cert-manager helm install version to latest v1.20.3

Prior Art

Based on: #1164 (post-1.20-release cleanup)

@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 8, 2026
@wallrj-cyberark wallrj-cyberark requested a review from hjoshi123 July 8, 2026 22:50
@wallrj-cyberark wallrj-cyberark requested a review from erikgb July 10, 2026 05:54
Comment thread config/plugins.yaml
master: v1.22
release-1.21: v1.21
release-1.20: v1.20
release-1.19: v1.19

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks strange, as older releases are still on this list.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — the prior art PRs (e.g. #1164, #1116) deliberately kept all the old milestone_applier entries. Reverted this change; plugins.yaml now has no diff against master.

cert-manager 1.19 is no longer supported since the release of 1.21,
so removing all the testing configuration, as per the release process:
https://cert-manager.io/docs/contributing/release-process/#minor-releases

Changes:
- Remove release-1.19 from prowgen knownBranches
- Delete release-1.19 prow job spec and associated periodics
- Remove release-1.19 branch-protection entry
- Remove release-1.19 milestone applier mapping
- Remove release-1.19 testgrid dashboard
- Bump cert-manager helm install version to v1.20.3
- Adjust cron schedules for release-1.20 and release-1.21 periodics;
  a side-effect of running make prowgen

Based on: cert-manager#1164

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@wallrj-cyberark wallrj-cyberark force-pushed the release-1.21-remove-unsupported branch from 232ed2f to 67cb156 Compare July 10, 2026 08:44
@wallrj-cyberark wallrj-cyberark requested a review from erikgb July 10, 2026 08:46

@erikgb erikgb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2026
@cert-manager-prow cert-manager-prow Bot merged commit 5d50992 into cert-manager:master Jul 10, 2026
6 checks passed
@cert-manager-prow

Copy link
Copy Markdown
Contributor

@wallrj-cyberark: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster default using the following files:
    • key cert-manager-release-1.19.yaml using file ``
    • key cert-manager-release-1.20.yaml using file config/jobs/cert-manager/cert-manager/release-1.20/cert-manager-release-1.20.yaml
    • key cert-manager-release-1.21.yaml using file config/jobs/cert-manager/cert-manager/release-1.21/cert-manager-release-1.21.yaml
  • config configmap in namespace default at cluster default using the following files:
    • key config.yaml using file config/config.yaml
Details

In response to this:

Motivation

cert-manager 1.19 is no longer supported since the release of 1.21, so removing all the testing configuration, as per the release process:

(final release only) Create a PR on cert-manager/testing, removing any unsupported release versions from prow config.

Changes

  • Remove release-1.19 from prowgen knownBranches
  • Delete release-1.19 prow job spec and associated periodics
  • Remove release-1.19 branch-protection entry
  • Remove release-1.19 milestone applier mapping
  • Remove release-1.19 testgrid dashboard
  • Bump cert-manager helm install version to v1.20.3
  • Adjust cron schedules for release-1.20 and release-1.21 periodics; a side-effect of running make prowgen

Test Plan

  • Ran make prowgen to regenerate job configurations
  • Verified all release-1.19 references removed from:
  • config/prowgen/prowspecs/specs.go
  • config/config.yaml (branch protection)
  • config/plugins.yaml (milestone applier)
  • config/testgrid/dashboards.yaml
  • config/jobs/cert-manager/cert-manager/release-1.19/
  • Updated cert-manager helm install version to latest v1.20.3

Prior Art

Based on: #1164 (post-1.20-release cleanup)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wallrj-cyberark wallrj-cyberark deleted the release-1.21-remove-unsupported branch July 10, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants