Document webhook certificate renewal after system suspend#2181
Merged
cert-manager-prow[bot] merged 1 commit intoJun 29, 2026
Merged
Conversation
cert-manager-prow
Bot
added
dco-signoff: yes
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
wallrj-cyberark
force-pushed
the
8464-webhook-renewal-docs
branch
from
dadf138 to
40e431c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documentation for the cert-manager 1.21 fix that ensures the webhook’s self-signed serving certificate renews correctly after system suspend (S3/S4) or VM live migration, preventing post-resume x509: certificate has expired or is not yet valid webhook failures.
Changes:
- Expands webhook troubleshooting guidance for expired serving certificates with root cause, upgrade guidance, and a restart workaround.
- Adds a “Major Themes” release-notes entry explaining the pre-1.21 failure mode and the 1.21 renewal behavior, plus a changelog bullet under “Bug or Regression”.
- Updates webhook concepts documentation to note renewal resilience since 1.21.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| content/docs/troubleshooting/webhook.md | Documents suspend/migration as a known cause of webhook serving cert expiry errors and provides remediation guidance. |
| content/docs/releases/release-notes/release-notes-1.21.md | Adds a Major Themes narrative and a Bug/Regression changelog entry for the webhook renewal fix. |
| content/docs/concepts/webhook.md | Notes that dynamic serving certificate renewal is resilient to suspend/migration starting in 1.21. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add a Major Themes entry to the 1.21 release notes explaining the webhook serving certificate renewal fix for system suspend and VM live migration (cert-manager/cert-manager#8464). Add a note to the webhook concepts page about the renewal resilience improvement in 1.21. Expand the troubleshooting section for "x509: certificate has expired" with the system suspend root cause and the upgrade path. Signed-off-by: Richard Wall <richard.wall@cyberark.com>
wallrj-cyberark
force-pushed
the
8464-webhook-renewal-docs
branch
from
40e431c to
3f1117c
Compare
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
lgtm
cert-manager-prow
Bot
merged commit 845087a
into
cert-manager:release-next
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview:
Pull Request Motivation
cert-manager/cert-manager#8464 fixes a bug where the webhook serving certificate
is not renewed after system suspend (S3/S4) or VM live migration. This PR adds
documentation for the fix ahead of the 1.21 release.
Changes
release-notes-1.21.md): add a Major Themes entryexplaining the bug (monotonic clock stops during suspend, one-shot timer never
fires) and the fix (periodic ticker polling wall-clock time). Add a Bug or
Regression changelog entry.
concepts/webhook.md): note that since 1.21, automaticrenewal is resilient to system suspend and VM live migration.
troubleshooting/webhook.md): expand thepreviously stub "x509: certificate has expired" section with the system suspend
root cause, upgrade path, and restart workaround.
Testing
Visual review of the three modified pages.