Skip to content

Comments

Add notes about container signing now it's enabled again#882

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:containersigning
Mar 28, 2022
Merged

Add notes about container signing now it's enabled again#882
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:containersigning

Conversation

@SgtCoDFish
Copy link
Member

Also remove "skip-signing" from release process because, y'know, we don't want to skip signing any more 😁

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2022

```console
curl -sSOL https://cert-manager.io/public-keys/cert-manager-pubkey-2021-09-20.pem
IMAGE_TAG=v1.8.0 # change as needed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: obviously this tag will fail right now because v1.8.0 hasn't been released, but I didn't want to put an alpha version here and it is clear from the text above that it's supported from v1.8.0 onwards

@netlify
Copy link

netlify bot commented Mar 25, 2022

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit e5d0055
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/623db1fa0e71dd0008eb117b
😎 Deploy Preview https://deploy-preview-882--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

also remove "skip-signing" from release process

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting how to verify the signatures!

I ran the instructions against v1.8.0-alpha.0 images and all worked as expected:

irbe@workspace$ cosign verify --signature-digest-algorithm sha512 --key cert-manager-pubkey-2021-09-20.pem quay.io/jetstack/cert-manager-webhook:$IMAGE_TAG

Verification for quay.io/jetstack/cert-manager-webhook:v1.8.0-alpha.0 --
The following checks were performed on each of these signatures:
  - The cosign claims were validated
  - The signatures were verified against the specified public key

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maelvls
Copy link
Member

maelvls commented Mar 25, 2022

I haven't tested the commands. That sounds like a good improvement. Thanks!

/lgtm

@SgtCoDFish
Copy link
Member Author

/retest

@jetstack-bot jetstack-bot merged commit a05a8fe into cert-manager:master Mar 28, 2022
@SgtCoDFish SgtCoDFish deleted the containersigning branch March 28, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants