Skip to content

Remove dict39 compatibility#2639

Merged
sebix merged 5 commits intocerttools:developfrom
Nakul-Rajpal:remove-Dict39-compatibility
Aug 21, 2025
Merged

Remove dict39 compatibility#2639
sebix merged 5 commits intocerttools:developfrom
Nakul-Rajpal:remove-Dict39-compatibility

Conversation

@Nakul-Rajpal
Copy link
Contributor

Fixes #2635

Summary

Removes the Dict39 alias across IntelMQ. Since IntelMQ now requires Python ≥3.9, the alias is no longer necessary.

Details

  • Deleted Dict39 = dict from intelmq/lib/datatypes.py
  • Replaced Dict39({...}) with standard {...} in:
    • intelmq/lib/bot.py
    • intelmq/tests/lib/test_bot_library_mode.py
  • Removed unused Dict39 imports.

Removed the Dict39 dependency on test_bot_library_mode.py
Copy link
Member

@sebix sebix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codestyle check fails:

intelmq/lib/bot.py:1530:26: E127 continuation line over-indented for visual indent
intelmq/lib/datatypes.py:140:1: W391 blank line at end of file

While you are at it, could you please add this snippet to the CHANGELOG.md in section Core?

- `intelmq.lib.datatypes`: Remove unneeded Dict39 alias (PR#2639 by Nakul Rajpal, fixes #2635)

@sebix sebix self-assigned this Aug 20, 2025
@Nakul-Rajpal
Copy link
Contributor Author

@sebix added said changes.

Copy link
Member

@sebix sebix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pycodestyle intelmq/{bots,lib,bin}
intelmq/lib/bot.py:1533:64: W292 no newline at end of file
intelmq/lib/datatypes.py:140:1: W391 blank line at end of file

@Nakul-Rajpal
Copy link
Contributor Author

@sebix Sorry for the minute changes. Everything should be ready now.

@sebix sebix merged commit 6d7efaf into certtools:develop Aug 21, 2025
20 checks passed
@sebix sebix added this to the 3.5.0 Feature Release milestone Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Dict39 compatibility shim

2 participants