bound session_id_len in mg_tls_server_recv_hello#3582
Closed
alhudz wants to merge 1 commit into
Closed
Conversation
Member
|
@alhudz could you report this to the https://github.com/cesanta/mongoose/security/advisories please ? |
Author
|
Sure, will do. |
Collaborator
|
@cpq YAD (Yet another duplicate). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mg_tls_server_recv_hello() reads session_id_len from the ClientHello at offset 43 and uses it to locate cipher_suites_len at rio->buf[44 + session_id_len], with only a rio->len >= 50 check. A client sending session_id_len up to 255 in a short record reads past the buffer (ASAN flags a heap-buffer-overflow ~250 bytes out). Bound it against rio->len before use, the same way the later length fields are checked.