Moved tcpdf_add_font calls from bootstrap, to package step (3.21)#1695
Merged
craigcomstock merged 1 commit into3.21.xfrom Apr 29, 2025
Merged
Moved tcpdf_add_font calls from bootstrap, to package step (3.21)#1695craigcomstock merged 1 commit into3.21.xfrom
craigcomstock merged 1 commit into3.21.xfrom
Conversation
|
Thank you for submitting a pull request! Maybe @craigcomstock can review this? |
tcpdf >= 6.8.0 requires php 7.1+ but we bootstrap for 3.21.x on debian-9 and sury.org has no stretch packages of newer php versions. Use built php instead. Ticket: ENT-12777 Changelog: none
craigcomstock
force-pushed
the
ENT-12777/3.21
branch
from
f5be54a to
177d48a
Compare
Contributor
Author
|
@cf-bottom jenkins no tests please, mostly just see if bootstrap-pr works and then might kill the rest of the build |
|
Alright, I triggered a build: [NO TESTS] Jenkins: https://ci.cfengine.com/job/pr-pipeline/12053/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12053/ |
larsewi
approved these changes
Apr 28, 2025
Contributor
Author
|
installed ubu20hub package and looks good! Will check they function properly in compliance report PDF generation. Seems to look good. |
Contributor
Author
Contributor
Author
|
Almost. Maybe need to be more careful about the ubu16hub build. |
craigcomstock
changed the title
Contributor
Author
|
I will fix ubu16hub on 3.21.x in a separate PR. Will merge this PR to get bootstrap-pr working again in nightlies. :) |
craigcomstock
force-pushed
the
ENT-12777/3.21
branch
from
723ae6e to
177d48a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tcpdf >= 6.8.0 requires php 7.1+ but we bootstrap for 3.21.x on debian-9 and sury.org has no stretch packages of newer php versions.
Use built php instead.
Ticket: ENT-12777
Changelog: none
ubu16hub only build: