Moved tcpdf_add_font calls from bootstrap, to package step (master)#1697
Merged
craigcomstock merged 3 commits intocfengine:masterfrom Apr 30, 2025
Merged
Moved tcpdf_add_font calls from bootstrap, to package step (master)#1697craigcomstock merged 3 commits intocfengine:masterfrom
craigcomstock merged 3 commits intocfengine:masterfrom
Conversation
This reverts commit 96a5930. Will re-work with a different fix. Ticket: ENT-12777 Changelog: none
This reverts commit 6cb6ae8. Will re-work with a different fix. Ticket: ENT-12777 Changelog: none
tcpdf >= 6.8.0 requires php 7.1+ but we bootstrap for 3.21.x on debian-9 and sury.org has no stretch packages of newer php versions. Use built php instead. Ticket: ENT-12777 Changelog: none (cherry picked from commit 177d48a)
craigcomstock
changed the title
Contributor
Author
|
@cf-bottom jenkins no tests, will cancel after bootstrap-pr job is green. |
|
Alright, I triggered a build: [NO TESTS] Jenkins: https://ci.cfengine.com/job/pr-pipeline/12057/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-12057/ |
aleksandrychev
approved these changes
Apr 29, 2025
larsewi
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bootstrap-pr job is green!
(I cancelled the rest of the job after, good enough for me)