Added github hostkeys to known_hosts in setup-ci-host.sh - #2400
Merged
Conversation
…oned to known_hosts Ticket: ENT-14397 Changelog: none
craigcomstock
force-pushed
the
ent-14397/master
branch
from
August 5, 2026 19:02
74a91eb to
2fc9fd0
Compare
Contributor
Author
|
see https://ci.cfengine.com/job/docs-pr/228/console for how this works, more quiet |
craigcomstock
marked this pull request as ready for review
August 5, 2026 19:02
nickanderson
approved these changes
Aug 5, 2026
nickanderson
left a comment
nickanderson
left a comment
Member
There was a problem hiding this comment.
It looked fine to me, but claude says: this only fixes container hosts. Regular build hosts take a different path through the code and still won't have GitHub's keys.
Contributor
Author
Claude is short-sighted and doesn't understand the scripts fully. The setup-cfengine-build-host.sh script only calls setup-ci-host.sh in case of containers. The rest are managed by the policy which includes provisioning the hostkeys to known_hosts. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.