ENT-5986: LMDB files are now created with correct permissions and group ownership (3.15)#4188
Closed
craigcomstock wants to merge 1 commit intocfengine:3.15.xfrom
Closed
ENT-5986: LMDB files are now created with correct permissions and group ownership (3.15)#4188craigcomstock wants to merge 1 commit intocfengine:3.15.xfrom
craigcomstock wants to merge 1 commit intocfengine:3.15.xfrom
Conversation
olehermanse
changed the title
Contributor
Author
|
This PR depends on 3.15.x libntech update PR here: #4190 |
olehermanse
previously requested changes
May 20, 2020
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
@craigcomstock 3.15 is now up to date with libntech master. Please remove the commit which updates libntech and rebase on latest 3.15.x
craigcomstock
force-pushed
the
ENT-5986/3.15.x
branch
4 times, most recently
from
897ba22 to
d23f74e
Compare
olehermanse
requested review from
olehermanse and
vpodzime
and removed request for
olehermanse and
vpodzime
When run as privileged user LMDB files will be created with system group matching MPF body perms system_owned(). When un-privileged, no change in group will be made. In both cases permissions will be 0600 as expected by MPF cfe_internal/enterprise/CFE_knowledge.cf. Ticket: ENT-5986 Changelog: Title (cherry picked from commit 079d333a48c03d4bcd4a3ded7b7eede07e91759c) Conflicts: libntech
craigcomstock
force-pushed
the
ENT-5986/3.15.x
branch
from
d23f74e to
ebd58c9
Compare
Contributor
Author
|
@cf-bottom jenkins with exotics please |
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/5166/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5166/ |
olehermanse
changed the title
vpodzime
reviewed
May 27, 2020
Contributor
vpodzime
left a comment
vpodzime
left a comment
There was a problem hiding this comment.
Looks good to me otherwise.
Contributor
Author
|
will not use this strategy, instead waiting on results of cfengine/masterfiles#1768 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When run as privileged user LMDB files will be created with
system group matching MPF body perms system_owned().
When un-privileged, no change in group will be made.
In both cases permissions will be 0600 as expected by MPF
cfe_internal/enterprise/CFE_knowledge.cf.
Ticket: ENT-5986
Changelog: Title
(cherry picked from commit 079d333a48c03d4bcd4a3ded7b7eede07e91759c)
Conflicts: libntech