Skip to content

CFE-3362 Changed group for state dir files promise to match defaults per OS #1768

Merged
nickanderson merged 1 commit intocfengine:masterfrom
craigcomstock:ENT-5986-v2/master
Jun 4, 2020
Merged

CFE-3362 Changed group for state dir files promise to match defaults per OS #1768
nickanderson merged 1 commit intocfengine:masterfrom
craigcomstock:ENT-5986-v2/master

Conversation

@craigcomstock
Copy link
Copy Markdown
Contributor

@craigcomstock craigcomstock commented May 28, 2020

Especially this concerns lmdb files.
system_owned perms body was used previously but for solaris systems the use
of "sys" group seems incorrect so changing to "root" for solaris is the
net result of this change.

Ticket: CFE-3362
Changelog: Title

merge with:
cfengine/core#4200

@craigcomstock craigcomstock added the WIP Work in Progress label May 28, 2020
@craigcomstock
Copy link
Copy Markdown
Contributor Author

@cf-bottom jenkins, thanks.

@cf-bottom
Copy link
Copy Markdown

@craigcomstock
Copy link
Copy Markdown
Contributor Author

@cf-bottom jenkins, thanks.

@cf-bottom
Copy link
Copy Markdown

@craigcomstock
Copy link
Copy Markdown
Contributor Author

@cf-bottom jenkins with exotics

@cf-bottom
Copy link
Copy Markdown

Comment thread cfe_internal/enterprise/CFE_knowledge.cf Outdated
@craigcomstock craigcomstock changed the title ENT-5986 Added state_dir_perms perms body to reflect default perms and group for state dir ENT-5986 Added default perms body for state dir to use root, 0600 and os appropriate group May 29, 2020
@craigcomstock craigcomstock removed the WIP Work in Progress label May 29, 2020
@craigcomstock
Copy link
Copy Markdown
Contributor Author

@cf-bottom jenkins with exotics. thanks! :)

@cf-bottom
Copy link
Copy Markdown

Alright, I triggered a build:

Build Status

(with exotics)

Jenkins: https://ci.cfengine.com/job/pr-pipeline/5187/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5187/

@nickanderson
Copy link
Copy Markdown
Member

For a previous diff that had execresult() for /usr/bin/id:
What about sys.user_data?

https://docs.cfengine.com/docs/3.15/reference-special-variables-sys.html#sys-user_data

Also getgid(), getuserinfo(), and getuid()****

@craigcomstock
Copy link
Copy Markdown
Contributor Author

For a previous diff that had execresult() for /usr/bin/id:
What about sys.user_data?

https://docs.cfengine.com/docs/3.15/reference-special-variables-sys.html#sys-user_data

Also getgid(), getuserinfo(), and getuid()****

Good tips. I was just doing debugging. Removed it. 👍

@craigcomstock
Copy link
Copy Markdown
Contributor Author

@cf-bottom jenkins with exotics again please, hopefully solaris sparc 11 will not have ssh errors this time.

@cf-bottom
Copy link
Copy Markdown

@craigcomstock
Copy link
Copy Markdown
Contributor Author

@cf-bottom jenkins with exotics

@cf-bottom
Copy link
Copy Markdown

Alright, I triggered a build:

Build Status

(with exotics)

Jenkins: https://ci.cfengine.com/job/pr-pipeline/5212/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5212/

@craigcomstock
Copy link
Copy Markdown
Contributor Author

Will re-work this PR as #1777, will close after sequential-tests retry is complete.

Especially this concerns lmdb files.
system_owned perms body was used previously but for solaris systems the use
of "sys" group seems incorrect so changing to "root" for solaris is the
net result of this change.

Ticket: CFE-3362
Changelog: Title
@craigcomstock craigcomstock changed the title ENT-5986 Added default perms body for state dir to use root, 0600 and os appropriate group CFE-3362 Changed group for state dir files promise to match defaults per OS Jun 4, 2020
@nickanderson nickanderson merged commit 5cfb768 into cfengine:master Jun 4, 2020
craigcomstock pushed a commit to craigcomstock/masterfiles that referenced this pull request Jun 9, 2020
CFE-3362 Changed group for state dir files promise to match defaults per OS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants