Do not record 'packages' promises skipped due to locking #4491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For other promise types, promises skipped due to locking only result in 'debug' log messages being emitted and cfPS() is not called. There's no reason why 'packages' promises should behave differently. Ticket: ENT-6553 Changelog: Reduced the noise caused by packages promises being skipped in evaluation passes 2 and 3
Contributor
Author
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/6090/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-6090/ |
|
This pull request fixes 1 alert when merging e88aef5 into 8f1fdd2 - view on LGTM.com fixed alerts:
|
nickanderson
approved these changes
Feb 4, 2021
Member
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
I think this makes sense since it's not skipped because it's out of context but I am not very clear on the specifics of when we should record a SKIPPED result.
olehermanse
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For other promise types, promises skipped due to locking only
result in 'debug' log messages being emitted and cfPS() is not
called. There's no reason why 'packages' promises should behave
differently.
Ticket: ENT-6553
Changelog: Reduced the noise caused by packages promises being skipped in evaluation passes 2 and 3