Skip to content

ENT-5986 Changed system_owned group for solaris back to default of root (3.12.x) #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
craigcomstock wants to merge 1 commit into from
Closed

ENT-5986 Changed system_owned group for solaris back to default of root (3.12.x) #1766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion cfe_internal/enterprise/CFE_knowledge.cf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ bundle agent cfe_internal_permissions

!(policy_server|am_policy_hub)::
"$(sys.statedir)/." -> { "ENT-4773" }
perms => system_owned( "0600" ),
perms => state_dir_perms(),
# Important to recurse across file system boundaries, as databases and or state are commonly on different filesystems
depth_search => recurse_with_base( inf ),
file_select => all;
Expand Down Expand Up @@ -357,3 +357,20 @@ body depth_search cfe_internal_docroot_application_perms
depth => "inf";
exclude_dirs => { "logs" };
}

############################################################################

body perms state_dir_perms
Copy link
Copy Markdown
Member

@nickanderson nickanderson May 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels redundant to say perms twice in the same line.

Copy link
Copy Markdown
Contributor Author

@craigcomstock craigcomstock May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions? I am working on another PR now for master first since we decided to unblock this from the release train.

{
mode => "0600";
owners => { "root" };

freebsd|openbsd|netbsd|darwin::
groups => { "wheel" };

aix::
groups => { "system" };

!(freebsd|openbsd|netbsd|darwin|aix)::
groups => { "root" };
Copy link
Copy Markdown
Member

@nickanderson nickanderson May 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows?

Copy link
Copy Markdown
Contributor Author

@craigcomstock craigcomstock May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. This wasn't handled before so must work as-is? How are windows perms handled? I can check/test.

}