ENT-5986 Changed system_owned group for solaris back to default of root (3.12.x)#1766
ENT-5986 Changed system_owned group for solaris back to default of root (3.12.x)#1766craigcomstock wants to merge 1 commit intocfengine:3.12.xfrom
Conversation
craigcomstock
force-pushed
the
ENT-5986/3.12.x
branch
from
7e95ff2 to
4444fb3
Compare
|
@cf-bottom jenkins with exotics |
craigcomstock
requested review from
nickanderson
and removed request for
nickanderson
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/5177/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5177/ |
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
I don't think we should change the meaning of body perms system_owned. I think it would be better to introduce a new perms body.
craigcomstock
force-pushed
the
ENT-5986/3.12.x
branch
from
4444fb3 to
9fbcc9d
Compare
…or state dir Especially this concerns lmdb files. system_owned perms body was used previously but for solaris systems the use of "sys" group seems incorrect so changing to "root" for solaris is the net result of this change. Ticket: ENT-5986 Changelog: Title
craigcomstock
force-pushed
the
ENT-5986/3.12.x
branch
from
9fbcc9d to
12f7133
Compare
|
|
||
| ############################################################################ | ||
|
|
||
| body perms state_dir_perms |
There was a problem hiding this comment.
feels redundant to say perms twice in the same line.
There was a problem hiding this comment.
Suggestions? I am working on another PR now for master first since we decided to unblock this from the release train.
| groups => { "system" }; | ||
|
|
||
| !(freebsd|openbsd|netbsd|darwin|aix):: | ||
| groups => { "root" }; |
There was a problem hiding this comment.
Right. This wasn't handled before so must work as-is? How are windows perms handled? I can check/test.
|
will cherry-pick results of this WIP: #1768 |
3 participants
In research on Solaris 10 and 11 it seems that "sys" is not used.
Ticket: ENT-5986
Changelog: Title
merge with:
cfengine/core#4199