Improve sampling evaluator results - #90
Merged
Merged
Conversation
willbarton
approved these changes
Aug 7, 2026
And add default values to result summary fields 'hits' and 'accounts_affected'
Generate the sample as EvaluatorResult IDs instead of AccountActivity IDs, then indicate the sample on the EvaluatorResult instead of on the EvaluatorResultSummary record. Then, simplify how we serve the sample records in the view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal ticket #1081
Previously, we would save a sample of each evaluator's results to an S3 bucket so that we can provide the sample quickly, even if the evaluator filter page is slow. Now that we're using a materialized view for evaluator results, we no longer need this performance "hack" in order to load that page quickly.
Testing
Screenshots
Notes
Todos
Checklist