Fix API response when size limit is exceeded - #251
Merged
Conversation
The current code has a bug - it should have raised a 404 error but instead returns the Http404 Python class, which triggers a 500 error to the user. This commit changes the logic to be consistent with other API validation errors, using the DRF ValidationError class. These trigger a 400 HTTP Bad Request response to the user.
Provide additional exception details when logging errors.
flacoman91
approved these changes
Jul 24, 2026
Member
|
Been occupied; thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#249 introduced a bug - it should have raised a 404 error but instead returns the
Http404Python class, which triggers a 500 error to the user.This commit changes the logic to be consistent with other API validation errors, using the DRF
ValidationErrorclass. These trigger a 400 HTTP Bad Request response to the user.I've also slightly improved error logging generally to make it easier to debug API errors.