Skip to content

Wire val_size through CLI and pipeline construction - #201

Draft
ch55secake with Copilot wants to merge 2 commits into
mainfrom
copilot/daily-audit-hyperion-codebase-again
Draft

Wire val_size through CLI and pipeline construction#201
ch55secake with Copilot wants to merge 2 commits into
mainfrom
copilot/daily-audit-hyperion-codebase-again

Conversation

Copilot AI commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Description

Daily audit surfaced a split-configuration gap: val_size existed in config/pipeline logic but could not be set via CLI/Makefile, so runs silently defaulted to 0.1. This PR makes validation split sizing externally configurable and consistently propagated.

Changes in this pull request

  • CLI/config wiring

    • Added --val-size to argument parsing in src/main.py.
    • Mapped parsed value into HyperionConfig(val_size=...).
  • Pipeline propagation

    • Passed config.val_size into both:
      • StackedModelTrainingPipeline(...)
      • TimeSeriesStackedModelTrainingPipeline(...)
  • Runtime entrypoint parity

    • Added VAL_SIZE ?= 0.1 in Makefile.
    • Included --val-size $(VAL_SIZE) in _RUN_ARGS.
  • Docs alignment

    • Updated README run examples and parameter table to include VAL_SIZE / --val-size.
  • Focused regression coverage

    • Added tests/test_main_parse_args.py for:
      • default val_size parsing
      • explicit --val-size override
parser.add_argument(
    "--val-size",
    type=float,
    default=defaults.val_size,
    help="Fraction of training data reserved for validation (0 < val_size < 1 - test_size).",
)

Copilot AI linked an issue Apr 22, 2026 that may be closed by this pull request
Agent-Logs-Url: https://github.com/ch55secake/hyperion/sessions/e7b0d513-ae2e-4ef9-92f8-cfa432d32add

Co-authored-by: ch55secake <87881861+ch55secake@users.noreply.github.com>
Copilot AI changed the title [WIP] Audit the Hyperion codebase for issues Wire val_size through CLI and pipeline construction Apr 22, 2026
Copilot AI requested a review from ch55secake April 22, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Daily Audit: 2026-04-22

2 participants