Conversation
|
Hmm travis is reporting "Error: No compatible version found: component-pin@'^1.0.4'", don't think it's related to this change. |
|
@keithamus can you please take a look? Thanks. |
|
cc @keithamus patch is really simple, should only take a second to review. It will make firefox dev a lot easier. Thanks! |
|
@simonzack sorry - I somehow missed this one! Looks like the build failed, but may be unrelated. I've re-run it. If it passes I'll merge. |
|
Still failing. Could you try rebasing @simonzack? |
|
@keithamus Thanks for taking a look. I just pulled and it is based on the latest commit (from 2013). The build does succeed for node v0.10 but fails for v.0.8, where the logs say that component could not be installed. The component page says it only supports node v0.10. |
|
@simonzack it sounds like something might be going a bit wrong here. Can I suggest you run the following: git remote rm upstream
git remote add upstream https://github.com/chaijs/assertion-error.git
git fetch -p upstream
git rebase upstream/master
git push origin masterEDIT: From what I can see your commit's parent points to cb277d2 so is most definitely out of date. |
|
@keithamus But isn't cb277d2 the latest commit on master? This is what the git hub page says:
|
|
Oh duh... I'm totally getting confused between repos now. Sorry @simonzack 😊. I think this is probably failing because of the fact Component no longer supports 0.8... We could probably drop support for 0.8 as no longer "officially" supported anyway. We dropped suport for 0.8 around the end of 2013 on mainline chai anyway: chaijs/chai@678c63e. I'll merge this one - despite the failures, and work on getting a new release which drops support. |
|
Great, looking forward to it! :) |
fixes chaijs/chai#100.