Skip to content

fixes .stack on firefox#2

Merged
keithamus merged 1 commit intochaijs:masterfrom
simonzack:master
Mar 2, 2015
Merged

fixes .stack on firefox#2
keithamus merged 1 commit intochaijs:masterfrom
simonzack:master

Conversation

@simonzack
Copy link
Copy Markdown
Contributor

@simonzack
Copy link
Copy Markdown
Contributor Author

Hmm travis is reporting "Error: No compatible version found: component-pin@'^1.0.4'", don't think it's related to this change.

@simonzack
Copy link
Copy Markdown
Contributor Author

@keithamus can you please take a look? Thanks.

@simonzack
Copy link
Copy Markdown
Contributor Author

cc @keithamus patch is really simple, should only take a second to review. It will make firefox dev a lot easier. Thanks!

@keithamus
Copy link
Copy Markdown
Member

@simonzack sorry - I somehow missed this one! Looks like the build failed, but may be unrelated. I've re-run it. If it passes I'll merge.

@keithamus
Copy link
Copy Markdown
Member

Still failing. Could you try rebasing @simonzack?

@simonzack
Copy link
Copy Markdown
Contributor Author

@keithamus Thanks for taking a look. I just pulled and it is based on the latest commit (from 2013). The build does succeed for node v0.10 but fails for v.0.8, where the logs say that component could not be installed. The component page says it only supports node v0.10.

@keithamus
Copy link
Copy Markdown
Member

@simonzack it sounds like something might be going a bit wrong here. Can I suggest you run the following:

git remote rm upstream
git remote add upstream https://github.com/chaijs/assertion-error.git
git fetch -p upstream
git rebase upstream/master
git push origin master

EDIT: From what I can see your commit's parent points to cb277d2 so is most definitely out of date.

@simonzack
Copy link
Copy Markdown
Contributor Author

@keithamus But isn't cb277d2 the latest commit on master? This is what the git hub page says:

latest commit cb277d2 Jake Luer logicalparadox authored on 9 Jun 2013

@keithamus
Copy link
Copy Markdown
Member

Oh duh... I'm totally getting confused between repos now. Sorry @simonzack 😊.

I think this is probably failing because of the fact Component no longer supports 0.8... We could probably drop support for 0.8 as no longer "officially" supported anyway. We dropped suport for 0.8 around the end of 2013 on mainline chai anyway: chaijs/chai@678c63e.

I'll merge this one - despite the failures, and work on getting a new release which drops support.

keithamus added a commit that referenced this pull request Mar 2, 2015
fixes `.stack` on firefox
@keithamus keithamus merged commit 7564725 into chaijs:master Mar 2, 2015
@simonzack
Copy link
Copy Markdown
Contributor Author

Great, looking forward to it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion.includeStack = true doesn't work on Firefox

2 participants