X/Discord/Telegram/Email Login QA - #110
Merged
Merged
Conversation
eldenpark
reviewed
Dec 12, 2025
| } | ||
|
|
||
| if (method !== "google" && method !== "x" && method !== "discord") { | ||
| if ( |
Contributor
There was a problem hiding this comment.
best time to define a function
isSupportedVendorType()
eldenpark
reviewed
Dec 12, 2025
| setSigningInState({ status: "signing-in" }); | ||
| await okoWallet.signIn(method as "google" | "x" | "discord"); | ||
| await okoWallet.signIn( | ||
| method as "google" | "x" | "discord" | "telegram" | "email", |
Contributor
There was a problem hiding this comment.
If the function above passes, this should be assumed.
eldenpark
reviewed
Dec 12, 2025
| WORKDIR /home/node/key_share_node/key_share_node/server | ||
|
|
||
| CMD [ "yarn", "start" ] | ||
| CMD [ "yarn", "start" ] No newline at end of file |
eldenpark
reviewed
Dec 12, 2025
| } catch (error) { | ||
| popupWindow.close(); | ||
| throw new Error( | ||
| `Failed to redirect popup to email login URL: ${error instanceof Error ? error.message : String(error)}`, |
eldenpark
reviewed
Dec 12, 2025
|
|
||
| const popupOrigin = new URL(this.sdkEndpoint).origin; | ||
|
|
||
| // Wait for nonce to be set, then redirect popup to actual email login URL |
Contributor
There was a problem hiding this comment.
This function I remember shouldn't use async method. Safari issue. Is nonce necessary?
Contributor
Author
There was a problem hiding this comment.
Popup opens immediately (about:blank) to bypass Safari blocker, then waits for nonce setup before redirect. Nonce is optional for Auth0 but added for security.
eldenpark
reviewed
Dec 12, 2025
| VITE_AMPLITUDE_API_KEY= | ||
| VITE_IPFS_GATEWAY_URL= No newline at end of file | ||
| VITE_IPFS_GATEWAY_URL= | ||
| VITE_TELEGRAM_BOT_NAME=telegram_bot_name No newline at end of file |
Contributor
|
@chihunmanse Is this review ready? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
CONTRIBUTING.mdand followed the guidelines.Summary
Links (Issue References, etc, if there's any)