OKO-373,OKO-388 - #111
Conversation
|
@editaahn Is this review ready? |
| @@ -1,18 +1,65 @@ | |||
| import cn from "classnames"; | |||
| import Image from "next/image"; | |||
| import { Typography } from "@oko-wallet-common-ui/typography/typography"; | |||
There was a problem hiding this comment.
"oko-wallet-common-ui" invalid usage here
There was a problem hiding this comment.
Oh, it happens 'cause I'm using auto import. I'll fix them right now
There was a problem hiding this comment.
Got it. Later, I can disable it so that no one has to pay attention. But it will come with a cost of re-compiling the common-ui package everytime (I'll do later though)
| text-align: center; | ||
| max-width: 498px; | ||
| white-space: pre-line; | ||
| } No newline at end of file |
| const nextConfig: NextConfig = { | ||
| /* config options here */ | ||
| typescript: { | ||
| ignoreBuildErrors: true, // Rita: it should be removed after modularChainInfo changes in Wallet packages |
|
@editaahn Is this merge ready? Or do you want to add more? |
|
There'll be a few more commits. Clara has started testing. I'll ping you when it's done! @eldenpark |
|
@eldenpark additional commits are ready for review! |
| modularChainInfo.evm.currencies[0].coinMinimalDenom === | ||
| currency.coinMinimalDenom | ||
| ) { | ||
| // Intentionally left empty: display the native currency (first in the list), even if its balance is zero. |
There was a problem hiding this comment.
Done! But it seems the formatter (Biome) doesn't break lines of annotations.
There was a problem hiding this comment.
thx for letting us know!
| modularChainInfo.evm.currencies[0].coinMinimalDenom === | ||
| currency.coinMinimalDenom | ||
| ) { | ||
| // Intentionally left empty: display the native currency (first in the list), even if its balance is zero. |
3 participants
Pull Request
CONTRIBUTING.mdand followed the guidelines.Summary
Links (Issue References, etc, if there's any)