fix(build): clone opts before appending to avoid cross-config stomp in concurrent resolves - #2487
Merged
markusthoemmes merged 1 commit intoSep 10, 2026
Conversation
…n concurrent resolves LockImageConfigurationWithPackages appended WithImageConfiguration onto the caller's opts slice. When that slice has spare capacity and is shared across concurrent LockImageConfiguration calls (e.g. resolving every image in a gallery at once), each call's append writes WithImageConfiguration into the same backing-array slot, so one image's configuration stomps a sibling's and the loser resolves against the wrong package set - surfacing as "unable to lock packages to a consistent version" with a package blank on one arch. Clone the opts slice first, matching the existing pattern in NewMultiArch, so each call appends into its own backing array. Confirmed with go test -race, which previously reported a data race here.
markusthoemmes
marked this pull request as ready for review
September 10, 2026 12:31
joshrwolf
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LockImageConfigurationWithPackages appended WithImageConfiguration onto the caller's opts slice. When that slice has spare capacity and is shared across concurrent LockImageConfiguration calls (e.g. resolving every image in a gallery at once), each call's append writes WithImageConfiguration into the same backing-array slot, so one image's configuration stomps a sibling's and the loser resolves against the wrong package set - surfacing as "unable to lock packages to a consistent version" with a package blank on one arch. Clone the opts slice first, matching the existing pattern in NewMultiArch, so each call appends into its own backing array. Confirmed with go test -race, which previously reported a data race here.