Check if frs Map is nil before ranging over it#462
Merged
egibs merged 2 commits intochainguard-dev:mainfrom Sep 16, 2024
Merged
Check if frs Map is nil before ranging over it#462egibs merged 2 commits intochainguard-dev:mainfrom
egibs merged 2 commits intochainguard-dev:mainfrom
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
tstromberg
approved these changes
Sep 16, 2024
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
added a commit
to egibs/malcontent
that referenced
this pull request
Sep 25, 2024
* Check if frs Map is nil before ranging over it Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> * Appease the linter Signed-off-by: egibs <20933572+egibs@users.noreply.github.com> --------- Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
imjasonh
pushed a commit
to wolfi-dev/os
that referenced
this pull request
Sep 30, 2024
While troubleshooting the `wolfictl check diff` panics in #29705, I noticed that the SDK image digest was fairly out of date (3+ weeks). This means that all of the recent `bincapz`/`malcontent` changes were not captured, including [this](chainguard-dev/malcontent#462) PR which resolves panics like the one seen in the aforementioned PR. This PR updates the SDK image digest to an image with the latest version of `malcontent` and the most recent `wolfictl` [commit](wolfi-dev/wolfictl@8f6fc7a) which will correctly locate the `malcontent` binary in SDK containers. Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #458
The
.jarfile in the aforementioned issue failed to extract:Which means the
frsMap was not populated (i.e., was stillnil) before we tried to use theRange()method (and we're passing in a pointer to the Map viafrs *sync.Map):This PR should handle cases like this more resiliently.