fix: add group reference to attestation API #1531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
javirln
reviewed
Nov 18, 2024
| } | ||
|
|
||
| if ev.PolicyReference != nil { | ||
| name, _ := ev.PolicyReference.GetAnnotations().AsMap()["organization"].(string) |
Member
There was a problem hiding this comment.
This won't work with old attestations right? Could we add a check to only add the organization name if the fields exists?
Member
Author
There was a problem hiding this comment.
If the key doesn't exist, or there are no annotations, orgName will be assigned an empty string "". I've tested it with references without groups and works as expected.
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
javirln
approved these changes
Nov 18, 2024
migmartri
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group reference was missing in attestation API responses. This PR fixes that.
Related to #1405