Skip to content

fix: add group reference to attestation API #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiparis merged 3 commits into from
Nov 19, 2024
Merged

fix: add group reference to attestation API #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c438c5
add group reference to attestation API
jiparis Nov 18, 2024
53bbc1b
fix
jiparis Nov 18, 2024
877c1e7
rename var
jiparis Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
510 changes: 267 additions & 243 deletions app/controlplane/api/controlplane/v1/response_messages.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions app/controlplane/api/controlplane/v1/response_messages.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ message PolicyEvaluation {
PolicyReference policy_reference = 10;
bool skipped = 12;
repeated string skip_reasons = 13;
PolicyReference group_reference = 15;
}

message PolicyViolation {
Expand All @@ -145,6 +146,7 @@ message PolicyViolation {
message PolicyReference {
string name = 1;
map<string, string> digest = 2;
string organization = 3;
}

message WorkflowContractItem {
Expand Down
34 changes: 33 additions & 1 deletion app/controlplane/api/gen/frontend/controlplane/v1/response_messages.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions app/controlplane/api/gen/jsonschema/controlplane.v1.PolicyEvaluation.jsonschema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions app/controlplane/api/gen/jsonschema/controlplane.v1.PolicyEvaluation.schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions app/controlplane/api/gen/jsonschema/controlplane.v1.PolicyReference.jsonschema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions app/controlplane/api/gen/jsonschema/controlplane.v1.PolicyReference.schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 12 additions & 2 deletions app/controlplane/internal/service/attestation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,9 +470,19 @@ func extractPolicyEvaluations(in map[string][]*chainloop.PolicyEvaluation) map[s
}

if ev.PolicyReference != nil {
orgName, _ := ev.PolicyReference.GetAnnotations().AsMap()["organization"].(string)
eval.PolicyReference = &cpAPI.PolicyReference{
Name: ev.PolicyReference.Name,
Digest: ev.PolicyReference.Digest,
Name: ev.PolicyReference.Name,
Digest: ev.PolicyReference.Digest,
Organization: orgName,
}
}
if ev.GroupReference != nil {
orgName, _ := ev.GroupReference.GetAnnotations().AsMap()["organization"].(string)
eval.GroupReference = &cpAPI.PolicyReference{
Name: ev.GroupReference.Name,
Digest: ev.GroupReference.Digest,
Organization: orgName,
}
}

Expand Down
Loading