Skip to content

chore: add integration permissions to api tokens #1543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiparis merged 1 commit into from
Nov 19, 2024
Merged

chore: add integration permissions to api tokens #1543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/controlplane/pkg/authz/authz.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,11 @@ var (
PolicyAvailableIntegrationRead = &Policy{ResourceAvailableIntegration, ActionRead}
// Registered integrations
PolicyRegisteredIntegrationList = &Policy{ResourceRegisteredIntegration, ActionList}
PolicyRegisteredIntegrationRead = &Policy{ResourceRegisteredIntegration, ActionRead}
PolicyRegisteredIntegrationAdd = &Policy{ResourceRegisteredIntegration, ActionCreate}
// Attached integrations
PolicyAttachedIntegrationList = &Policy{ResourceAttachedIntegration, ActionList}
PolicyAttachedIntegrationList = &Policy{ResourceAttachedIntegration, ActionList}
PolicyAttachedIntegrationAttach = &Policy{ResourceAttachedIntegration, ActionCreate}
// Org Metrics
PolicyOrgMetricsRead = &Policy{ResourceOrgMetric, ActionList}
// Robot Account
Expand Down Expand Up @@ -171,9 +174,12 @@ var ServerOperationsMap = map[string][]*Policy{
// Available integrations
"/controlplane.v1.IntegrationsService/ListAvailable": {PolicyAvailableIntegrationList, PolicyAvailableIntegrationRead},
// Registered integrations
"/controlplane.v1.IntegrationsService/ListRegistrations": {PolicyRegisteredIntegrationList},
"/controlplane.v1.IntegrationsService/ListRegistrations": {PolicyRegisteredIntegrationList},
"/controlplane.v1.IntegrationsService/DescribeRegistration": {PolicyRegisteredIntegrationRead},
"/controlplane.v1.IntegrationsService/Register": {PolicyRegisteredIntegrationAdd},
// Attached integrations
"/controlplane.v1.IntegrationsService/ListAttachments": {PolicyAttachedIntegrationList},
"/controlplane.v1.IntegrationsService/Attach": {PolicyAttachedIntegrationAttach},
// Metrics
"/controlplane.v1.OrgMetricsService/.*": {PolicyOrgMetricsRead},
// Robot Account
Expand Down
9 changes: 9 additions & 0 deletions app/controlplane/pkg/biz/apitoken.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,15 @@ func NewAPITokenUseCase(apiTokenRepo APITokenRepo, conf *conf.Auth, authzE *auth
authz.PolicyOrganizationRead,
// to create robot accounts
authz.PolicyRobotAccountCreate,

// to attach integrations
authz.PolicyAvailableIntegrationRead,
authz.PolicyAvailableIntegrationList,
authz.PolicyRegisteredIntegrationList,
authz.PolicyRegisteredIntegrationRead,
authz.PolicyRegisteredIntegrationAdd,
authz.PolicyAttachedIntegrationList,
authz.PolicyAttachedIntegrationAttach,
},
}

Expand Down
Loading