fix(cli): print usable Jupyter entry URL#294
Merged
Merged
Conversation
|
PR Title: fix(cli): print usable Jupyter entry URL Commit: 本次变更在 代码逻辑简洁,边界场景(尾部斜杠、根路径 |
Collaborator
Author
|
Manual verification completed with real Docker sandboxes:
The test sandboxes remained running during browser verification. |
eetoc
marked this pull request as ready for review
July 14, 2026 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/lab?token=...URL when the daemon returns an exposed notebook URLVerification
go test ./cmd/agent-compose -run 'TestIntegrationCLIRun(JupyterWithoutExposePrintsTokenRedirectEntry|SendsJupyterExpose)|TestJupyterBrowserLocation' -count=1\n-go test ./cmd/agent-compose -count=1\n-task lint\n- real Docker sandbox: the non-exposed URL redirected to a tokenized JupyterLab URL and completed with HTTP 200\n- real Docker sandbox: the exposed tokenized URL opened JupyterLab directly with HTTP 200\n\n## Known environment failures\n\n-task testreacheddeploy/install_test.shand failed an existing incomplete-rollback message assertion (recovery was incomplete)\n- the full Linux artifact build could not refresh runtime artifacts because Docker Hub timed out while fetchinggolang:1-alpine