[MOBTECH-787] Semantic Token 변경사항 반영#115
Merged
Merged
Conversation
개요이 변경 사항은 의미론적 색상 토큰에서 11개의 표면 강조 색상 케이스와 그래디언트 케이스를 제거하고, 새로운 fillGreyLight 케이스를 추가합니다. 또한 타이포그래피 메서드에서 semanticColor 매개변수의 기본값을 제거하여 호출자가 명시적으로 제공하도록 변경합니다. 변경 사항
예상 코드 리뷰 난이도🎯 2 (Simple) | ⏱️ ~12분 토끼의 축하시
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
bonoogi
commented
Jan 14, 2026
Comment on lines
-183
to
-193
| case surfaceAccentBlue | ||
| case surfaceAccentCobalt | ||
| case surfaceAccentGreen | ||
| case surfaceAccentNavy | ||
| case surfaceAccentOlive | ||
| case surfaceAccentOrange | ||
| case surfaceAccentPink | ||
| case surfaceAccentPurple | ||
| case surfaceAccentRed | ||
| case surfaceAccentTeal | ||
| case surfaceAccentYellow |
Contributor
Author
There was a problem hiding this comment.
|
|
||
| // MARK: - Gradient | ||
| case gradientAccentGreen | ||
| case gradientAccentGreenHeavy |
Contributor
Author
There was a problem hiding this comment.
요약하자면 gradientAccentGreenHeavy 토큰의 값이 이상해서 수정하던 와중에 컴케를 해보니 light만 있으면 되는거였음(gradientAccentGreenHeavy는 사용처 없음)
bonoogi
commented
Jan 14, 2026
| public func attributedString( | ||
| _ component: BezierComponentable, | ||
| text: String, | ||
| semanticColor: SemanticColor = .txtBlackDarkest, |
Contributor
Author
There was a problem hiding this comment.
신버전 토큰을 받는 메서드와 구버전 토큰을 받는 메서드 둘 다 기본값을 받다보니 시그니처가 동일해보이는 문제가 있어서 구버전 토큰을 받는 쪽은 기본값을 안받도록 해두었습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
기한
요약
fillGreyLight토큰 추가 (Light: grey25, Dark: grey900)gradientAccentGreenHeavy,surfaceAccent*11개)세부적인 작업 내용
추가된 토큰 (1개)
fillGreyLight: Light →grey25, Dark →grey900제거된 토큰 (12개)
gradientAccentGreenHeavysurfaceAccentBluesurfaceAccentCobaltsurfaceAccentGreensurfaceAccentNavysurfaceAccentOlivesurfaceAccentOrangesurfaceAccentPinksurfaceAccentPurplesurfaceAccentRedsurfaceAccentTealsurfaceAccentYellow참고 링크
셀프 체크
Summary by CodeRabbit
릴리스 노트
새로운 기능
변경 사항
✏️ Tip: You can customize this high-level summary in your review settings.