feat: scheduled primitives — extension model + standalone activity support#2
Open
chaptersix wants to merge 3 commits intomasterfrom
Open
feat: scheduled primitives — extension model + standalone activity support#2chaptersix wants to merge 3 commits intomasterfrom
chaptersix wants to merge 3 commits intomasterfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the
ScheduleAPI to support multiple action primitives, with standalone activities as the first non-workflow primitive. Adds the four extension seams described in the Scheduled Primitives Design:ScheduleAction.start_activityoneof variant referencingNewActivityExecutionInfo.ScheduleActionStatus,ScheduleActionKind,ScheduledExecutionReference,ScheduleActivityExecution— that replace per-primitive field growth onScheduleActionResult,ScheduleInfo, andScheduleListInfo.ScheduleActionResultfields (start_execution_result,start_execution_status,start_execution_link) used by all non-workflow action types.Link.Schedulevariant so the scheduler can be a typed link target rather than overloadingLink.WorkflowEvent.Existing workflow-specific fields are frozen for backward compatibility:
ScheduleAction.start_workflow(field 1)ScheduleActionResult.start_workflow_result(11) /start_workflow_status(12)ScheduleInfo.running_workflows(9)ScheduleListInfo.workflow_type(2)Commits
feat: add Link.Schedule variant for bi-directional schedule linking— adds the typed schedule link variant, modeled afterLink.Activity(also a CHASM component without an event history).feat: add schedule extension types for standalone activity actions— addsScheduleActionStatus,ScheduleActionKind,ScheduledExecutionReference,ScheduleActivityExecution, thestart_activityoneof variant, and generic fields onScheduleActionResult/ScheduleInfo/ScheduleListInfo.feat: add NewActivityExecutionInfo message for schedule actions— shared config message for starting a standalone activity in different contexts (mirrorsNewWorkflowExecutionInfo). Carries activity-specific config; request-level fields stay onStartActivityExecutionRequest.Verification
buf build— passesbuf lint— passesbuf breaking --against upstream/master— passes (no breaking changes)Test plan
api-gobindings on top of this branchstart_activitydispatch through the scheduler (downstream PR)start_activity, observerunning_executionsandrecent_actions[].start_execution_resultStacked
PR 2 (
alex/sch-primitives-nexus) stacks on this branch and addsstart_nexus_operationas the second primitive.