feat: scheduled primitives — standalone Nexus operation support (stacked on #2)#3
Open
chaptersix wants to merge 1 commit intoalex/sch-primitives-activityfrom
Open
feat: scheduled primitives — standalone Nexus operation support (stacked on #2)#3chaptersix wants to merge 1 commit intoalex/sch-primitives-activityfrom
chaptersix wants to merge 1 commit intoalex/sch-primitives-activityfrom
Conversation
Adds NewNexusOperationExecutionInfo as a shared config message for starting a standalone Nexus operation in different contexts, mirroring the NewWorkflowExecutionInfo and NewActivityExecutionInfo pattern. It carries the operation-specific config fields (operation_id, endpoint, service, operation, input, the three timeouts, search_attributes, nexus_header, user_metadata). Request-level fields (request_id, id_reuse_policy, id_conflict_policy) stay on StartNexusOperationExecutionRequest and are not part of the schedule action config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacks on #2. Adds standalone Nexus operations as the second primitive under the schedule-action extension model. Mirrors the activity-primitive shape from the parent PR — no new lifecycle, no new ScheduleActionResult/Info fields, just new oneof variants in the extension seams.
Changes:
temporal/api/nexus/v1/message.proto: addsNewNexusOperationExecutionInfo, a shared config message for starting a standalone Nexus operation in different contexts (mirrorsNewWorkflowExecutionInfoandNewActivityExecutionInfo). Carries operation-specific config (operation_id,endpoint,service,operation,input, the three timeouts,search_attributes,nexus_header,user_metadata). Request-level fields (request_id,id_reuse_policy,id_conflict_policy) stay onStartNexusOperationExecutionRequestand are not part of the schedule action config.temporal/api/schedule/v1/message.proto:ScheduleActionKind: addsSCHEDULE_ACTION_KIND_NEXUS_OPERATION = 3.ScheduledExecutionReference: addsScheduleNexusOperationExecution nexus_operation = 3variant.ScheduleNexusOperationExecutionmessage (operation_id,run_id) — typed running-execution handle for the genericrunning_executionslist.ScheduleAction: addsstart_nexus_operation = 3variant referencingNewNexusOperationExecutionInfo. The scheduler generates a uniqueoperation_idper run (mirrors theactivity_idrule onstart_activity).The generic
ScheduleActionResult.start_execution_*fields,ScheduleInfo.running_executions, andScheduleListInfo.action_kind/action_type_nameintroduced in #2 already cover Nexus operations — no further field changes here.Verification
buf build— passesbuf lint— passesbuf breaking --against upstream/master— passes (no breaking changes)Test plan
api-gobindings on top of this stacked branchstart_nexus_operationdispatch through the scheduler (downstream PR)start_nexus_operation, observerunning_executionsandrecent_actions[].start_execution_result