Skip to content

Fix: Windows: first character input lost on successive programs#1355

Closed
joshallenit wants to merge 2 commits intocharmbracelet:mainfrom
joshallenit:josh-allen-it/Fix-Windows-first-character-input-lost-on-successive-programs
Closed

Fix: Windows: first character input lost on successive programs#1355
joshallenit wants to merge 2 commits intocharmbracelet:mainfrom
joshallenit:josh-allen-it/Fix-Windows-first-character-input-lost-on-successive-programs

Conversation

@joshallenit
Copy link
Contributor

@joshallenit joshallenit commented Mar 17, 2025

Explanation here: #1167 (comment)

Note: I don't think it is possible to unit test this in a meaningful way because to reproduce the issue requires using console input, but please correct me if I'm wrong.

Issue: #1167

@joshallenit joshallenit marked this pull request as ready for review March 17, 2025 08:22
@joshallenit
Copy link
Contributor Author

Looks like main branch is broken as all of the PR's are failing for the same reason. go mod tidy needs to be called, although that might not be the only reason. When I run go mod tidy all it does it update the go version, which I don't think is desired, at least not in this PR. Can a code owner fix the main branch?

@meowgorithm
Copy link
Member

Hey there! Thanks for flagging this; we're looking into it right now.

@meowgorithm
Copy link
Member

Alright, the build's fixed on main. We're also working on the lint stuff now as well.

@andreynering
Copy link
Member

@joshallenit The CI is green again. You can rebase your branch with main.

@joshallenit joshallenit force-pushed the josh-allen-it/Fix-Windows-first-character-input-lost-on-successive-programs branch from fa5e3cc to d79c34f Compare March 20, 2025 03:32
@charmbracelet charmbracelet deleted a comment from codecov bot Mar 20, 2025
@codecov
Copy link

codecov bot commented Mar 20, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@joshallenit joshallenit deleted the josh-allen-it/Fix-Windows-first-character-input-lost-on-successive-programs branch March 23, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants