fix: enable job control for interactive shells on Unix - #48
Merged
Conversation
taciturnaxolotl
force-pushed
the
fix/pty-job-control
branch
from
July 30, 2026 00:44
472f664 to
14922ea
Compare
Start child processes in a new session with the PTY as controlling terminal. Without this, bash prints "no job control in this shell" and job control features like Ctrl+Z, bg, and fg do not work. Co-authored-by: Pete Woods <email@pete-woods.com>
taciturnaxolotl
force-pushed
the
fix/pty-job-control
branch
from
July 30, 2026 00:44
14922ea to
7988dba
Compare
Coverage Report for CI Build 30503582511Coverage decreased (-0.2%) to 62.158%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
taciturnaxolotl
added a commit
that referenced
this pull request
Jul 30, 2026
The job control change from #48 unconditionally set Setsid and Setctty on every command started via Pty.Start, which broke callers that manage their own SysProcAttr or run multiple commands sequentially against the same PTY. Job control is now opt-in via the new WithJobControl() option. The default behavior matches the pre-#48 contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interactive shells started over SSH were printing
bash: no job control in this shellbecause child processes were not started in a new session with the PTY as their controlling terminal. This broke job control features like Ctrl+Z,bg, andfg.The fix sets
SetsidandSetcttyon the child process'sSysProcAttrbefore starting it, matching the behavior ofcreack/pty'sStartWithAttrs.Fixes #41