fix: close leaked process and pipe handles on Windows PTY sessions - #49
Merged
Conversation
taciturnaxolotl
force-pushed
the
fix/conpty-handle-leak
branch
from
July 30, 2026 00:21
e0f83ed to
a0b63fe
Compare
Each PTY session on Windows leaked roughly one handle because the raw process handle returned by ConPty.Spawn was never closed. Upgrade charmbracelet/x/conpty to v0.2.0 which closes all four pipe handles properly, and close the spawned process handle once the process exits or the session context is cancelled.
taciturnaxolotl
force-pushed
the
fix/conpty-handle-leak
branch
from
July 30, 2026 00:42
a0b63fe to
eb5d22b
Compare
Coverage Report for CI Build 30503519225Coverage remained the same at 62.359%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each PTY session on Windows leaked roughly one handle because the raw
process handle returned by ConPty.Spawn was never closed. Upgrade
charmbracelet/x/conpty to v0.2.0 which closes all four pipe handles
properly, and close the spawned process handle once the process exits
or the session context is cancelled.
fixes #20