fix: cherry-pick upstream fixes from gliderlabs/ssh - #51
Merged
Conversation
From https://staticcheck.dev/docs/checks#SA4011: SA4011 - Break statement with no effect. Did you mean to break out of an outer loop? In Go, the break statement only exits the innermost loop it's currently in. If you're seeing the "ineffective break statement" warning, it's likely because you have a break statement inside a nested loop, but you intended to exit the outer loop. Updating with a `return` to exit the goroutine entirely. The unit test itself isn't affected; it passes before and after this change.
On my system, the message wasn't being printed when `sftp` connection exited (I types `exit` in sftp). Let me know if I misunderstood something.
Coverage Report for CI Build 30506992601Coverage decreased (-0.08%) to 62.381%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
When a server only defines SubsystemHandlers (e.g. SFTP) without a session Handler, an SSH client sending a shell or exec request causes a nil pointer dereference panic at session.go:261. Add a nil check for sess.handler before accepting the request. When nil, the request is rejected with Reply(false, nil) instead of crashing. Fixes gliderlabs#237
This error can be used in ConnectionFailedCallback to know error with error.Is().
only disable client auth when it's explicitly disabled or the auth callkbacks on both `*Server` and `ServerConfig` are nil
taciturnaxolotl
force-pushed
the
upstream-fixes
branch
from
July 30, 2026 01:55
f199d35 to
4bc63b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks six fixes from upstream gliderlabs/ssh that address several bugs:
ConnectionCloseCallbackfor connection lifecycle hooks (useful for rate limiting)ServerConfigCallbackwhen setting NoClientAuth gliderlabs/ssh#163: respectServerConfigCallbackauth callbacks when settingNoClientAuthErrPermissionDeniedsentinel instead of inlinefmt.Errorfcallscontext_test.go