feat: use log/slog for internal diagnostics - #53
Merged
Conversation
Replace swallowed errors and TODO comments with structured log/slog calls. No new API surface: users who want diagnostics set their own slog handler (e.g. charmbracelet/log), users who don't see nothing. Addresses gliderlabs#254, gliderlabs#96, gliderlabs#10.
Coverage Report for CI Build 30508246940Coverage decreased (-0.05%) to 61.905%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces silently swallowed errors and stale
TODO: log ...comments with structuredlog/slogcalls across tcpip.go and session.go.No new API surface or dependencies. Users who want diagnostics set their own slog handler (e.g. charmbracelet/log); users who don't see nothing, since slog's default handler discards below Info.
Sites covered:
PTTY copy errors are intentionally left silent since client disconnects make them noisy.
Addresses gliderlabs#254, gliderlabs#96, gliderlabs#10.