Communication Over Time: totals by default, selectable y-axis scale; reorder Tools menu - #152
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ions Previously the reader converted every per-interval count to a rate at load time by dividing by intervalSize/1000. Since intervalSize is in microseconds, that divisor is the interval length in milliseconds, so the values labeled "/s" were actually per-millisecond, 1000x larger than the label claimed. The graph also could not show plain totals. Keep raw per-interval counts in the data arrays and apply scaling only at display time, selected by a new row of radio buttons below the view selection: - Totals per interval (default): unnormalized counts summed over the selected PEs - Rate (per second): counts divided by the interval length in seconds (correct microsecond conversion), aggregated over the selected PEs - Rate per PE (per second): the above divided by the number of selected PEs, showing average per-PE communication intensity Popups show both the rate and the underlying total in rate modes, and plain counts otherwise. Also fix the External Node Msgs Recv popup, which displayed the value from the External (PE) array instead of the External Node array. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ritvikrao
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Communication Over Time: fix rate normalization and make the y-axis scale selectable. The reader previously converted per-interval counts to rates at load time by dividing by
intervalSize/1000. SinceintervalSizeis in microseconds, the values labeled "/s" were actually per-millisecond — 1000x larger than the label claimed — and plain totals could not be displayed at all. The data arrays now keep raw per-interval counts and scaling is applied at display time, chosen by a new radio row below the view selection:In rate modes the hover popups show both the rate and the underlying total.
Fix a popup bug: the External Node Msgs Recv popup displayed the value from the External (PE) array instead of the External Node array.
Tools menu reorder (trivial, separate commit): Time Profile, Usage Profile, and Timelines are now the first three entries; the rest keep their previous order.
Testing
Built with
gradle copyJarToBin(JDK 17) and verified against a 120-PE reconverse trace: all eight views display correct totals by default, the two rate modes scale and relabel the y-axis and popups as expected, and toggling the scale redraws the currently selected view immediately.🤖 Generated with Claude Code